Skip to content

feat: add support for unknown in typescript#2194

Closed
RichiCoder1 wants to merge 3 commits into
glideapps:masterfrom
RichiCoder1:patch-1
Closed

feat: add support for unknown in typescript#2194
RichiCoder1 wants to merge 3 commits into
glideapps:masterfrom
RichiCoder1:patch-1

Conversation

@RichiCoder1

@RichiCoder1 RichiCoder1 commented Mar 1, 2023

Copy link
Copy Markdown

Adds support for unknown (and it's flow equivalent) in TypeScript.

First PR and I made this constribution mostly via the GitHub UI, happy to do more if needed!

Closes #1619

@RichiCoder1
feat: add support for unknown in typescript
762064c 
Adds support for `unknown` (and it's flow equivalent) in TypeScript.

Closes glideapps#1619
@RichiCoder1
fix template fail
1f2a3af
@dvdsgl

dvdsgl commented Mar 1, 2023

Copy link
Copy Markdown
Member

Awesome! Please add an option for this in the typescript test fixture.

@RichiCoder1

RichiCoder1 commented Mar 1, 2023

Copy link
Copy Markdown
Author

@dvdsgl absolutely! Pulled down source to attempt this, but I'm not sure where in tests I'd add the specific options?

Also ran into this issue while executing npm run test:

[INFO] Compiling 3 source files to /workspaces/quicktype/test/fixtures/java/target/classes
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] Source option 6 is no longer supported. Use 7 or later.
[ERROR] Target option 6 is no longer supported. Use 7 or later.
[INFO] 2 errors 
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  4.015 s
[INFO] Finished at: 2023-03-01T20:56:22Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project QuickTypeTest: Compilation failure: Compilation failure: 
[ERROR] Source option 6 is no longer supported. Use 7 or later.
[ERROR] Target option 6 is no longer supported. Use 7 or later.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

@dvdsgl

dvdsgl commented Mar 1, 2023

Copy link
Copy Markdown
Member

Check the README for details. You want quicktestRenderSettings or some such name.

@RichiCoder1

RichiCoder1 commented Mar 1, 2023

Copy link
Copy Markdown
Author

https://github.com/quicktype/quicktype/blob/master/test/languages.ts#L694 it looks like?

@RichiCoder1

RichiCoder1 commented Mar 2, 2023

Copy link
Copy Markdown
Author

Yup that was it. Actually found an unrelated bug, but icing this PR for a second. The source uses "any" as a catchall in a number of places where a more specific type (Record<key, unknown>, IConvertable) would make more sense which means a decent size chunk-o-changes will likely need to be made to the JavaScript output to emit the correct and specific types.

@dvdsgl dvdsgl marked this pull request as draft June 3, 2023 23:32
@SBrandeis

SBrandeis commented Jan 22, 2024

Copy link
Copy Markdown

@RichiCoder1 are there any plans to move forward with this PR?

k-vasily added a commit to k-vasily/quicktype that referenced this pull request Mar 11, 2026
@k-vasily @claude
feat: add --prefer-unknown option for TypeScript and Flow
acba960 
Add a `--prefer-unknown` CLI flag that emits `unknown` instead of `any`
in TypeScript output, and `mixed` instead of `any` in Flow output.

This is a fresh implementation of the feature proposed in PR glideapps#2194 by
@RichiCoder1, adapted to the current codebase structure where
TypeScriptFlow was split into multiple files.

Closes glideapps#1619

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@k-vasily k-vasily mentioned this pull request Mar 11, 2026
Open
4 tasks
k-vasily added a commit to k-vasily/quicktype that referenced this pull request Mar 11, 2026
@k-vasily
feat: add --prefer-unknown option for TypeScript and Flow
bf6b307 
Add a `--prefer-unknown` CLI flag that emits `unknown` instead of `any`
in TypeScript output, and `mixed` instead of `any` in Flow output.

This is a fresh implementation of the feature proposed in PR glideapps#2194 by
@RichiCoder1, adapted to the current codebase structure where
TypeScriptFlow was split into multiple files.

Closes glideapps#1619
@schani

schani commented Jul 6, 2026

Copy link
Copy Markdown
Member

Closing this draft as superseded: #2862 is a fresh implementation of the same feature (unknown for TypeScript, mixed for Flow) adapted to the current codebase where TypeScriptFlow has been split into multiple files, and it credits this PR and its author. The branch here has also conflicted with master since the renderer reorganization. Thanks @RichiCoder1 for the original work — the feature lives on in #2862.

@schani schani closed this Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add flag for typescript to use unknown instead of any

4 participants

@RichiCoder1 @dvdsgl @SBrandeis @schani